Code Review Myths That Are Slowing You Down
Ever waited three days for a review on a 500-line PR? I have. It's frustrating. You think the reviewer is being thorough, but honestly, they're just busy. And that's the core issue: we've built code review around myths that don't serve us. Let's tear them down.
Myth 1: The goal of code review is to find bugs
If you think code review is primarily a bug hunt, you're missing the point. In a study at Google, researchers found that the four key expectations of code review are education, maintaining norms, gatekeeping, and accident prevention—bug finding is not the primary focus (Modern Code Review: A Case Study at Google). Similarly, research at Microsoft showed that while finding defects is the stated motivation, the real benefits are knowledge transfer, team awareness, and better solutions (Bacchelli & Bird, ICSE 2013). So stop obsessing over nitpicks and start focusing on design and clarity.
Myth 2: Bigger PRs are more efficient
I remember a colleague who opened a 2,000-line PR and expected a thorough review. That's insane. Google's own guidance says a change of 100 lines is usually reasonable, and 1,000 lines is usually too large (Google Engineering Practices - Small CLs). Their internal data shows the median change size is just 24 lines—over 10% are one-liners (Modern Code Review: A Case Study at Google). Small changes are reviewed faster, more thoroughly, and are less likely to introduce bugs. If your PR is huge, split it up. You'll get better reviews and faster merges.
Myth 3: Reviews should be thorough, even if slow
I've seen reviewers take a week to respond, thinking they're being careful. But Google's rule is clear: the maximum time to respond to a review request is one business day (Google Engineering Practices - Speed of Code Reviews). In fact, their data shows a median time to first feedback of under an hour for small changes (Modern Code Review: A Case Study at Google). Speed matters more than perfection. Don't interrupt your flow to review, but if you're not in the middle of something, review immediately. Slow reviews destroy team velocity and morale.
Myth 4: You need formal inspections to be serious
Some teams think code review means a formal Fagan inspection with a moderator and meetings. That's outdated. Modern code review is informal, tool-based, and asynchronous (Modern Code Review: A Case Study at Google). And it works: across Google, Microsoft, AMD, and open source, practices have converged on short, frequent, pre-commit reviews (Rigby & Bird). So skip the meetings, use a pull request tool, and keep it lightweight.
What actually works: a pragmatic approach
Here's my recommendation, backed by evidence:
- Keep changes small—under 400 lines if possible, ideally around 100 (Google Engineering Practices - Small CLs).
- Automate the mechanical stuff: linters, static analysis, and dependency scanners handle style and security patterns (Google Engineering Practices - Code Review).
- Use 'LGTM with comments' when you trust the author to address minor issues—don't block the merge (Google Engineering Practices - Speed of Code Reviews).
- Review design first, then functionality, complexity, tests, naming, and comments (Google Engineering Practices - What to look for in a code review).
Comparison: Review Tools and Their Features
| Tool | Key Feature | Best For |
|---|---|---|
| GitHub | PR reviews with Approve/Request changes, CODEOWNERS, branch protection | Open source and GitHub-hosted projects |
| GitLab | Required approvals, merge request widgets, code quality reports | Enterprise with compliance needs |
| Gerrit | Web-based review built on Git, focuses on each commit | Teams wanting strict per-change review |
Conclusion: Stop chasing perfection, start shipping better code
Code review isn't about catching every bug—it's about improving code health over time. Google's senior principle says to approve a change once it definitely improves overall code health, even if it's not perfect (Google Engineering Practices - Standard of Code Review). So next time you're reviewing, ask: does this make the codebase better? If yes, approve it, move on, and keep the momentum. Your team will thank you.
Sources
- Google Engineering Practices (code review) - https://google.github.io/eng-practices/review/
- Modern Code Review: A Case Study at Google - https://www.papercache.org/papers/mlsys/system/2026/03/25/modern-code-review-a-case-study-at-google
- Modern Code Review: Expectations, Outcomes, and Challenges - https://www.microsoft.com/en-us/research/publication/expectations-outcomes-and-challenges-of-modern-code-review/
- Google Engineering Practices - Small CLs - https://google.github.io/eng-practices/review/developer/small-cls.html
- Google Engineering Practices - Speed of Code Reviews - https://google.github.io/eng-practices/review/reviewer/speed.html
Comments (0)
Please sign in to post a comment.
Don't have an account? Create one
No comments yet. Be the first to comment!